[Tasks] Rename generate property in task specs
#930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanouticelina
requested review from
SBrandeis,
gary149,
julien-c and
osanseviero
as code owners
Wauplin
approved these changes
Sep 27, 2024
Contributor
Wauplin
left a comment
Wauplin
left a comment
There was a problem hiding this comment.
Looks good, thanks!
For other reviewers, Inference API / Inference Endpoints won't support generation_parameters yet but since they already don't support generate, that's not a breaking change 😄
Contributor
Author
|
Thanks for the reviews! let's merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #923
This PR updates the task specs to rename the
generateproperty togeneration_parameters. This change aligns with the discussion in the issue.Key changes:
generatetogeneration_parametersin the specs forautomatic-speech-recognition,image-to-text,text-to-audioandtext-to-speechtasks.